Skip to content

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 13, 2025

Remove the redundant models field from VLLMEndpoint configuration. Model-to-endpoint mapping is now solely determined by the preferred_endpoints field in model_config, eliminating the need for bidirectional association.

Changes:

  • Remove Models field from VLLMEndpoint struct
  • Update GetEndpointsForModel to use only preferred_endpoints
  • Update GetAllModels to retrieve models from model_config keys
  • Update all configuration files to remove models field
  • Update all tests to reflect the new configuration structure
  • Update TypeScript interface in dashboard frontend

This simplifies the configuration and removes potential inconsistencies between models and preferred_endpoints.

Remove the redundant models field from VLLMEndpoint configuration.
Model-to-endpoint mapping is now solely determined by the
preferred_endpoints field in model_config, eliminating the need
for bidirectional association.

Changes:
- Remove Models field from VLLMEndpoint struct
- Update GetEndpointsForModel to use only preferred_endpoints
- Update GetAllModels to retrieve models from model_config keys
- Update all configuration files to remove models field
- Update all tests to reflect the new configuration structure
- Update TypeScript interface in dashboard frontend

This simplifies the configuration and removes potential
inconsistencies between models and preferred_endpoints.

Signed-off-by: bitliu <[email protected]>
Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit d2eeec1
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68ecf3e67559720008815332
😎 Deploy Preview https://deploy-preview-413--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 13, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 config

Owners: @rootfs
Files changed:

  • config/config-mcp-classifier-example.yaml
  • config/config.development.yaml
  • config/config.e2e.yaml
  • config/config.production.yaml
  • config/config.recipe-accuracy.yaml
  • config/config.recipe-latency.yaml
  • config/config.recipe-token-efficiency.yaml
  • config/config.testing.yaml
  • config/config.yaml
  • config/examples/system_prompt_example.yaml

📁 dashboard

Owners: @JaredforReal, @Xunzhuo
Files changed:

  • dashboard/frontend/src/pages/ConfigPage.tsx

📁 deploy

Owners: @rootfs, @Xunzhuo
Files changed:

  • deploy/kubernetes/config.yaml
  • deploy/kubernetes/istio/config.yaml
  • deploy/openshift/config-openshift.yaml

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/api/server_test.go
  • src/semantic-router/pkg/config/config.go
  • src/semantic-router/pkg/config/config_test.go
  • src/semantic-router/pkg/config/validation_test.go
  • src/semantic-router/pkg/extproc/endpoint_selection_test.go
  • src/semantic-router/pkg/extproc/models_endpoint_test.go
  • src/semantic-router/pkg/extproc/test_utils_test.go

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/installation/configuration.md
  • website/docs/installation/installation.md
  • website/docs/training/model-performance-eval.md
  • website/docs/tutorials/content-safety/pii-detection.md
  • website/docs/tutorials/intelligent-route/reasoning.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
@rootfs rootfs merged commit 45240d8 into main Oct 13, 2025
22 checks passed
@rootfs
Copy link
Collaborator

rootfs commented Oct 13, 2025

cc @yossiovadia for e2e tests

joyful-ii-V-I pushed a commit to joyful-ii-V-I/semantic-router that referenced this pull request Oct 13, 2025
…ct#413)

* refactor(config): remove models field from vLLM endpoints

Remove the redundant models field from VLLMEndpoint configuration.
Model-to-endpoint mapping is now solely determined by the
preferred_endpoints field in model_config, eliminating the need
for bidirectional association.

Changes:
- Remove Models field from VLLMEndpoint struct
- Update GetEndpointsForModel to use only preferred_endpoints
- Update GetAllModels to retrieve models from model_config keys
- Update all configuration files to remove models field
- Update all tests to reflect the new configuration structure
- Update TypeScript interface in dashboard frontend

This simplifies the configuration and removes potential
inconsistencies between models and preferred_endpoints.

Signed-off-by: bitliu <[email protected]>

* more

Signed-off-by: bitliu <[email protected]>

* more

Signed-off-by: bitliu <[email protected]>

---------

Signed-off-by: bitliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants